Skip to content

Flinksql support standalone deploy mode #13495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidzollo merged 1 commit into from
Feb 5, 2023
Merged

Flinksql support standalone deploy mode #13495

davidzollo merged 1 commit into from
Feb 5, 2023

Conversation

@shenyun
Copy link
Contributor

@shenyun shenyun commented Feb 2, 2023

Purpose of the pull request

feature flinksql support standalone deploy mode

@github-actions github-actions bot added backend UI ui and front end related labels Feb 2, 2023
@SbloodyS SbloodyS added 3.2.0 for 3.2.0 version feature new feature first time contributor First-time contributor labels Feb 2, 2023
@SbloodyS SbloodyS added this to the 3.2.0 milestone Feb 2, 2023
@SbloodyS SbloodyS added the miss:docs missing documents in PR label Feb 2, 2023
SbloodyS
SbloodyS reviewed Feb 2, 2023
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some docs.

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2023 •
edited
Loading

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.61%. Comparing base (5fb6035) to head (85b22d6).
⚠️ Report is 1089 commits behind head on dev.

Files with missing lines Patch % Lines
...hinscheduler/plugin/task/flink/FlinkArgsUtils.java 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##                dev   #13495   +/-   ##
=========================================
  Coverage     39.60%   39.61%           
  Complexity     4357     4357           
=========================================
  Files          1097     1097           
  Lines         41164    41169    +5     
  Branches       4716     4717    +1     
=========================================
+ Hits          16305    16310    +5     
+ Misses        23047    23046    -1     
- Partials       1812     1813    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

72.7% 72.7% Coverage
0.0% 0.0% Duplication

Amy0104
Amy0104 reviewed Feb 2, 2023
View reviewed changes
Copy link
Member

@Amy0104 Amy0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The front end part LGTM.

EricGao888
EricGao888 approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@EricGao888 EricGao888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it would be better if u could add a UT case to https://github.com/apache/dolphinscheduler/blob/dev/dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/test/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkArgsUtilsTest.java

ruanwenjun
ruanwenjun approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ruanwenjun ruanwenjun changed the title feature flinksql support standalone deploy mode Flinksql support standalone deploy mode Feb 3, 2023
@davidzollo davidzollo merged commit 8fa90c2 into apache:dev Feb 5, 2023
@davidzollo
Copy link
Contributor

davidzollo commented Feb 5, 2023

thanks for your first contribution, I'm looking forward to your deep participation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SbloodyS SbloodyS SbloodyS left review comments

@Amy0104 Amy0104 Amy0104 left review comments

@ruanwenjun ruanwenjun ruanwenjun approved these changes

@EricGao888 EricGao888 EricGao888 approved these changes

@songjianet songjianet Awaiting requested review from songjianet songjianet is a code owner

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@zhuangchong zhuangchong Awaiting requested review from zhuangchong

Assignees

@shenyun shenyun

Labels

3.2.0 for 3.2.0 version backend feature new feature first time contributor First-time contributor miss:docs missing documents in PR UI ui and front end related

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

7 participants

@shenyun @codecov-commenter @davidzollo @SbloodyS @ruanwenjun @EricGao888 @Amy0104