[feature][api-datasource]add redshift auth mode to get connection by access key #13379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tianqi-Dotes
requested review from
Amy0104,
kezhenxu94 and
songjianet
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| redshiftDatasourceParamDTO.setMode(connectionParams.getMode()); | ||
| redshiftDatasourceParamDTO.setDbUser(connectionParams.getDbUser()); | ||
| if (connectionParams.getMode().equals(RedshiftAuthMode.PASSWORD)) { | ||
| redshiftDatasourceParamDTO.setPort(Integer.parseInt(hostPortArray[0].split(Constants.COLON)[1])); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException
| if (hostPortArray[0].contains(Constants.COLON)) { | ||
| String portString = hostPortArray[0].split(Constants.COLON)[1]; | ||
| if (StringUtils.isNumeric(portString)) { | ||
| redshiftDatasourceParamDTO.setPort(Integer.parseInt(portString)); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException
Codecov Report
@@ Coverage Diff @@
## dev #13379 +/- ##
============================================
+ Coverage 39.46% 39.52% +0.06%
- Complexity 4308 4324 +16
============================================
Files 1083 1084 +1
Lines 40742 40916 +174
Branches 4670 4696 +26
============================================
+ Hits 16080 16174 +94
- Misses 22875 22938 +63
- Partials 1787 1804 +17
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
@Tianqi-Dotes please update the doc together. |
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
add redshift auth mode to get connection by access key
#13039
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md