Skip to content

[Feature][DataSource]Add trino datasource plugin #12911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ruanwenjun merged 14 commits into from
Nov 23, 2022
Merged

[Feature][DataSource]Add trino datasource plugin #12911

ruanwenjun merged 14 commits into from
Nov 23, 2022

Conversation

@Zephyrcf
Copy link
Contributor

@Zephyrcf Zephyrcf commented Nov 15, 2022 •
edited
Loading

Purpose of the pull request

Brief change log

Add trino data source plugin, version 402.

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@github-actions github-actions bot added backend UI ui and front end related labels Nov 15, 2022
@mergeable mergeable bot removed UI ui and front end related backend labels Nov 15, 2022
@github-actions github-actions bot added backend UI ui and front end related labels Nov 15, 2022
@Zephyrcf Zephyrcf changed the title [Improvement][DataSource]Add trino datasource type [Improvement][DataSource]Add trino datasource plugin Nov 15, 2022
DarkAssassinator
DarkAssassinator reviewed Nov 16, 2022
View reviewed changes
@DarkAssassinator
Copy link
Contributor

DarkAssassinator commented Nov 16, 2022

@insist777 please run mvn spotless:apply to fix failed CI.

ruanwenjun
ruanwenjun reviewed Nov 16, 2022
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2022 •
edited
Loading

Codecov Report

Merging #12911 (88845f8) into dev (92a9b7e) will decrease coverage by 0.08%.
The diff coverage is 51.51%.

@@             Coverage Diff              @@
##                dev   #12911      +/-   ##
============================================
- Coverage     39.44%   39.36%   -0.09%     
- Complexity     4244     4269      +25     
============================================
  Files          1052     1067      +15     
  Lines         39859    40116     +257     
  Branches       4586     4606      +20     
============================================
+ Hits          15722    15790      +68     
- Misses        22359    22549     +190     
+ Partials       1778     1777       -1
Impacted Files Coverage Δ
...cheduler/common/constants/DataSourceConstants.java 0.00% <ø> (ø)
...plugin/datasource/trino/TrinoDataSourceClient.java 0.00% <0.00%> (ø)
.../org/apache/dolphinscheduler/spi/enums/DbType.java 0.00% <0.00%> (ø)
...atasource/trino/param/TrinoDataSourceParamDTO.java 33.33% <33.33%> (ø)
...lugin/datasource/trino/TrinoDataSourceChannel.java 50.00% <50.00%> (ø)
...n/datasource/trino/param/TrinoConnectionParam.java 50.00% <50.00%> (ø)
...tasource/trino/param/TrinoDataSourceProcessor.java 52.83% <52.83%> (ø)
...atasource/trino/TrinoDataSourceChannelFactory.java 100.00% <100.00%> (ø)
...lphinscheduler/plugin/kubeflow/KubeflowHelper.java 81.39% <0.00%> (-5.45%) ⬇️
...eduler/api/service/impl/DataSourceServiceImpl.java 50.75% <0.00%> (-1.02%) ⬇️
... and 18 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Zephyrcf Zephyrcf requested review from DarkAssassinator and removed request for Amy0104, caishunfeng, kezhenxu94 and songjianet November 16, 2022 11:11
@Zephyrcf Zephyrcf requested review from DarkAssassinator and ruanwenjun and removed request for DarkAssassinator and ruanwenjun November 16, 2022 11:11
@SbloodyS SbloodyS changed the title [Improvement][DataSource]Add trino datasource plugin [Feature][DataSource]Add trino datasource plugin Nov 17, 2022
@SbloodyS SbloodyS added this to the 3.2.0 milestone Nov 17, 2022
@SbloodyS SbloodyS added feature new feature 3.2.0 for 3.2.0 version labels Nov 17, 2022
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 21, 2022
View reviewed changes
...java/org/apache/dolphinscheduler/plugin/datasource/trino/param/TrinoDataSourceProcessor.java
TrinoDataSourceParamDTO TrinoDatasourceParamDTO = new TrinoDataSourceParamDTO();
String[] split = hostPortArray[0].split(Constants.COLON);
TrinoDatasourceParamDTO.setHost(split[0]);
TrinoDatasourceParamDTO.setPort(Integer.valueOf(split[1]));

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException

Potential uncaught 'java.lang.NumberFormatException'.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 21, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 17 Code Smells

51.4% 51.4% Coverage
3.2% 3.2% Duplication

caishunfeng
caishunfeng approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ruanwenjun
ruanwenjun approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit b40c63f into apache:dev Nov 23, 2022
@Zephyrcf Zephyrcf deleted the Datasource_Trino branch November 23, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caishunfeng caishunfeng caishunfeng approved these changes

@ruanwenjun ruanwenjun ruanwenjun approved these changes

@zhongjiajie zhongjiajie Awaiting requested review from zhongjiajie

@Tianqi-Dotes Tianqi-Dotes Awaiting requested review from Tianqi-Dotes

@EricGao888 EricGao888 Awaiting requested review from EricGao888 EricGao888 is a code owner

+1 more reviewer

@DarkAssassinator DarkAssassinator DarkAssassinator left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Zephyrcf Zephyrcf

Labels

3.2.0 for 3.2.0 version backend document feature new feature priority:middle UI ui and front end related

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

8 participants

@Zephyrcf @DarkAssassinator @codecov-commenter @caishunfeng @ruanwenjun @SbloodyS @EricGao888 @cloudzzz996