Skip to content

[Feature-12827] add icon in idea #12829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ruanwenjun merged 1 commit into from
Nov 10, 2022
Merged

[Feature-12827] add icon in idea #12829

ruanwenjun merged 1 commit into from
Nov 10, 2022

Conversation

@muggleChen
Copy link
Contributor

@muggleChen muggleChen commented Nov 9, 2022 •
edited by SbloodyS
Loading

Purpose of the pull request

add cion inidea

Brief change log

Add icon.png to .idea folder
.gitignore does not ignore the icon.png under .idea

Verify this pull request

This pull request is code cleanup without any test coverage.

close #12827

@SbloodyS SbloodyS added feature new feature backend labels Nov 10, 2022
@SbloodyS SbloodyS changed the title [Feature-12827][hotfix] add icon in idea [Feature-12827] add icon in idea Nov 10, 2022
@SbloodyS SbloodyS added this to the 3.2.0 milestone Nov 10, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 10, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

kezhenxu94
kezhenxu94 approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@ruanwenjun ruanwenjun added the improvement make more easy to user or prompt friendly label Nov 10, 2022
@ruanwenjun ruanwenjun merged commit 5b7a609 into apache:dev Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng

@ruanwenjun ruanwenjun Awaiting requested review from ruanwenjun

Assignees

@muggleChen muggleChen

Labels

backend feature new feature improvement make more easy to user or prompt friendly

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

[Feature] add icon in Intellijidea and toolbox

4 participants

@muggleChen @kezhenxu94 @SbloodyS @ruanwenjun