[chore] Separate Python API into another repository #12779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, our Python API code is a module in apache/dolphinscheduler codebase, each time users change Python API code, they need to run all requests CI check for dolphinscheduler and Python API, But if the user does only change Python code, it could be merged if Python API CI pass and do not dependent on others CI. Besides, we release Python API as the same version of dolphinscheduler. It is easy for user to match Python API version. But when Python API does not change any code, but dolphinscheduler release a bugfix version, Python API has to release the new version to match dolphinscheduler. This happened when we released Python API 2.0.6 and 2.0.7. 2.0.6 and 2.0.7 is bugfix version, and Python API does not change any code, so the PyPI package is the same. Separate Python API also makes our code more sense, we will have more distinguished code in dolphinscheduler and Python API new repository. Have separate issue tracker and changelog for information to users. see more detail in mail thread: https://lists.apache.org/thread/4z7l5l54c4d81smjlk1n8nq380p9f0oo
Codecov Report
@@ Coverage Diff @@
## dev #12779 +/- ##
============================================
- Coverage 39.18% 39.11% -0.07%
+ Complexity 4212 4209 -3
============================================
Files 1045 1046 +1
Lines 39719 39733 +14
Branches 4575 4558 -17
============================================
- Hits 15562 15540 -22
- Misses 22387 22428 +41
+ Partials 1770 1765 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed!
|
zhongjiajie
added a commit
to zhongjiajie/dolphinscheduler-website
that referenced
this pull request
Nov 9, 2022
zhongjiajie
requested review from
EricGao888,
SbloodyS,
Tianqi-Dotes,
caishunfeng and
kezhenxu94
as code owners
kezhenxu94
approved these changes
Nov 9, 2022
zhongjiajie
added a commit
to apache/dolphinscheduler-website
that referenced
this pull request
Nov 9, 2022
zhongjiajie
added a commit
to zhongjiajie/dolphinscheduler
that referenced
this pull request
Nov 10, 2022
jieguangzhou
pushed a commit
that referenced
this pull request
Nov 10, 2022
* [fix][doc] Dead link for python api ref: #12779 and apache/dolphinscheduler-sdk-python#1 * fix dead link
3 tasks
zhuangchong
pushed a commit
that referenced
this pull request
Jan 3, 2023
zhuangchong
pushed a commit
that referenced
this pull request
Jan 3, 2023
* [fix][doc] Dead link for python api ref: #12779 and apache/dolphinscheduler-sdk-python#1 * fix dead link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, our Python API code is a module in apache/dolphinscheduler codebase,
each time users change Python API code, they need to run all requests CI check
for dolphinscheduler and Python API, But if the user does only change Python
code, it could be merged if Python API CI pass and do not dependent on others CI.
Besides, we release Python API as the same version of dolphinscheduler. It is
easy for user to match Python API version. But when Python API does not change
any code, but dolphinscheduler release a bugfix version, Python API has to
release the new version to match dolphinscheduler. This happened when we
released Python API 2.0.6 and 2.0.7. 2.0.6 and 2.0.7 is bugfix version, and
Python API does not change any code, so the PyPI package is the same.
Separate Python API also makes our code more sense, we will have more
distinguished code in dolphinscheduler and Python API new repository.
Have separate issue tracker and changelog for information to users.
ref PR in other repository: apache/dolphinscheduler-sdk-python#1
see more detail in mail thread: https://lists.apache.org/thread/4z7l5l54c4d81smjlk1n8nq380p9f0oo