Skip to content

[Refactor]migrate some task dao functions from ProcessServiceImpl to dao modules. #12505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
caishunfeng merged 9 commits into from
Oct 26, 2022
Merged

[Refactor]migrate some task dao functions from ProcessServiceImpl to dao modules. #12505

caishunfeng merged 9 commits into from
Oct 26, 2022

Conversation

@DarkAssassinator
Copy link
Contributor

@DarkAssassinator DarkAssassinator commented Oct 23, 2022

Purpose of the pull request

Brief change log

  • Move some taskInstance dao function to DAO module
  • Move some taskDefinition dao functions to DAO moudle
  • Move some taskDefinitionLog dao functions to DAO moudle
  • Move some ProcessInstanceMap dao function to DAO moudle

Verify this pull request

This pull request is already covered by existing tests

@ruanwenjun ruanwenjun added the improvement make more easy to user or prompt friendly label Oct 23, 2022
@ruanwenjun ruanwenjun added this to the 3.2.0 milestone Oct 23, 2022
@BongBongBang BongBongBang mentioned this pull request Oct 24, 2022
Merged
caishunfeng
caishunfeng previously approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

@DarkAssassinator DarkAssassinator requested review from caishunfeng and removed request for SbloodyS and ruanwenjun October 24, 2022 14:51
@caishunfeng
Copy link
Contributor

caishunfeng commented Oct 25, 2022

rerun the fail CI

@caishunfeng
Copy link
Contributor

caishunfeng commented Oct 25, 2022

Hi @DarkAssassinator Please check the fail CI.

@DarkAssassinator
Copy link
Contributor Author

DarkAssassinator commented Oct 25, 2022

Hi @DarkAssassinator Please check the fail CI.

ohh, I'm to blame carelessness, after we commit the review suggest, just commit it online, forget add lombok.NonNull import, i will fix it tonight. Thx

@DarkAssassinator DarkAssassinator force-pushed the dev_yann_refactor_issue#12469 branch from 25b45fc to 36f8177 Compare October 25, 2022 14:48
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 25, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

16.7% 16.7% Coverage
0.9% 0.9% Duplication

@DarkAssassinator
Copy link
Contributor Author

DarkAssassinator commented Oct 26, 2022

Hi @DarkAssassinator Please check the fail CI.

done

@caishunfeng caishunfeng merged commit 04aa125 into apache:dev Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caishunfeng caishunfeng caishunfeng approved these changes

Assignees

@DarkAssassinator DarkAssassinator

Labels

backend improvement make more easy to user or prompt friendly refactor

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

[Refactor] Migrate all taskInstance-related interface functions from ProcessServiceImpl

3 participants

@DarkAssassinator @caishunfeng @ruanwenjun