[Refactor] Migrate all command-related interface functions from ProcessServiceImpl #12474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkAssassinator
requested review from
SbloodyS,
caishunfeng and
ruanwenjun
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...cheduler-service/src/test/java/org/apache/dolphinscheduler/service/utils/ParamUtilsTest.java
Fixed
Show fixed
Hide fixed
...er-service/src/main/java/org/apache/dolphinscheduler/service/command/CommandServiceImpl.java
Fixed
Show fixed
Hide fixed
ruanwenjun
reviewed
Oct 22, 2022
...eduler-service/src/main/java/org/apache/dolphinscheduler/service/command/CommandService.java
Outdated
Show resolved
Hide resolved
...eduler-service/src/main/java/org/apache/dolphinscheduler/service/command/CommandService.java
Show resolved
Hide resolved
...eduler-service/src/main/java/org/apache/dolphinscheduler/service/command/CommandService.java
Outdated
Show resolved
Hide resolved
DarkAssassinator
force-pushed
the
dev_yann_refactor_issue#12468
branch
from
35f4c81 to
47fabf9
Compare
Codecov Report
@@ Coverage Diff @@
## dev #12474 +/- ##
============================================
+ Coverage 39.41% 39.43% +0.02%
- Complexity 4214 4216 +2
============================================
Files 1039 1041 +2
Lines 39140 39160 +20
Branches 4475 4478 +3
============================================
+ Hits 15426 15442 +16
- Misses 21941 21949 +8
+ Partials 1773 1769 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed! |
DarkAssassinator
requested review from
ruanwenjun
and removed request for
SbloodyS and
caishunfeng
ruanwenjun
approved these changes
Oct 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Brief change log
CommandServiceParamUtilsVerify this pull request
This pull request is already covered by existing tests