Skip to content

[Improvement-12446][CI] Run mvn spotless apply #12447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
EricGao888 merged 1 commit into from
Oct 20, 2022
Merged

[Improvement-12446][CI] Run mvn spotless apply #12447

EricGao888 merged 1 commit into from
Oct 20, 2022

Conversation

@DarkAssassinator
Copy link
Contributor

@DarkAssassinator DarkAssassinator commented Oct 19, 2022

Purpose of the pull request

Brief change log

Just mvn spotless:apply

Verify this pull request

@EricGao888 EricGao888 added the improvement make more easy to user or prompt friendly label Oct 19, 2022
@EricGao888 EricGao888 added this to the 3.2.0 milestone Oct 19, 2022
@DarkAssassinator DarkAssassinator changed the title [Fix-12446][CI]fix CI API Test spotless check [Improvement-12446][CI] Run mvn spotless apply Oct 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022 •
edited
Loading

Codecov Report

Merging #12447 (1266cae) into dev (97edc7d) will increase coverage by 0.12%.
The diff coverage is 65.86%.

❗ Current head 1266cae differs from pull request most recent head 41a2ef1. Consider uploading reports for the commit 41a2ef1 to get more accurate results

@@             Coverage Diff              @@
##                dev   #12447      +/-   ##
============================================
+ Coverage     39.23%   39.35%   +0.12%     
+ Complexity     4213     4211       -2     
============================================
  Files          1040     1040              
  Lines         38793    39157     +364     
  Branches       4462     4482      +20     
============================================
+ Hits          15219    15412     +193     
- Misses        21800    21970     +170     
- Partials       1774     1775       +1
Impacted Files Coverage Δ
...plugin/alert/dingtalk/DingTalkParamsConstants.java 0.00% <ø> (ø)
...cheduler/plugin/alert/email/EmailAlertChannel.java 47.61% <ø> (ø)
...inscheduler/plugin/alert/email/EmailConstants.java 0.00% <ø> (ø)
...eduler/plugin/alert/email/MailParamsConstants.java 0.00% <ø> (ø)
...olphinscheduler/plugin/alert/email/MailSender.java 50.68% <0.00%> (-0.35%) ⬇️
...gin/alert/email/exception/AlertEmailException.java 50.00% <ø> (ø)
...ugin/alert/email/template/DefaultHTMLTemplate.java 79.24% <0.00%> (-1.53%) ⬇️
...eduler/plugin/alert/feishu/FeiShuAlertChannel.java 16.66% <ø> (ø)
...ler/plugin/alert/feishu/FeiShuParamsConstants.java 0.00% <ø> (ø)
...hinscheduler/plugin/alert/feishu/FeiShuSender.java 46.55% <0.00%> (-1.24%) ⬇️
... and 505 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 19, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 34 Code Smells

48.8% 48.8% Coverage
0.8% 0.8% Duplication

@EricGao888
Copy link
Member

EricGao888 commented Oct 19, 2022

I've rerun the failed CI checks.

@EricGao888 EricGao888 merged commit 0eef2e3 into apache:dev Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EricGao888 EricGao888 EricGao888 approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

Assignees

@DarkAssassinator DarkAssassinator

Labels

backend improvement make more easy to user or prompt friendly

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

[Improvment] [Style] API Test spotless check failed.

3 participants

@DarkAssassinator @codecov-commenter @EricGao888