Skip to content

[Migrate][Test] Migrate other UT cases from jUnit 4 to 5, change @Ignore to @Disable #12382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ruanwenjun merged 1 commit into from
Oct 16, 2022
Merged

[Migrate][Test] Migrate other UT cases from jUnit 4 to 5, change @Ignore to @Disable #12382

ruanwenjun merged 1 commit into from
Oct 16, 2022

Conversation

@DarkAssassinator
Copy link
Contributor

@DarkAssassinator DarkAssassinator commented Oct 14, 2022

Purpose of the pull request

Brief change log

  • Migrate some UR cases from Junit4 to Junit5

Verify this pull request

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 25 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@caishunfeng caishunfeng added the improvement make more easy to user or prompt friendly label Oct 15, 2022
@caishunfeng caishunfeng added this to the 3.2.0 milestone Oct 15, 2022
caishunfeng
caishunfeng approved these changes Oct 15, 2022
View reviewed changes
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

EricGao888
EricGao888 approved these changes Oct 15, 2022
View reviewed changes
Copy link
Member

@EricGao888 EricGao888 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. I've restarted the failed CI.

@ruanwenjun ruanwenjun changed the title [Migrate][Test] Migrate other UT cases from jUnit 4 to 5 [Migrate][Test] Migrate other UT cases from jUnit 4 to 5, change @Ignore to @Disable Oct 16, 2022
@ruanwenjun ruanwenjun merged commit 7aa8a77 into apache:dev Oct 16, 2022
@DarkAssassinator DarkAssassinator deleted the dev_yann_junit5_others branch October 16, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caishunfeng caishunfeng caishunfeng approved these changes

@EricGao888 EricGao888 EricGao888 approved these changes

@zhongjiajie zhongjiajie Awaiting requested review from zhongjiajie

@Tianqi-Dotes Tianqi-Dotes Awaiting requested review from Tianqi-Dotes

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

@zhuangchong zhuangchong Awaiting requested review from zhuangchong

Assignees

@DarkAssassinator DarkAssassinator

Labels

backend document improvement make more easy to user or prompt friendly test

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@DarkAssassinator @caishunfeng @EricGao888 @ruanwenjun