Skip to content

[Migrate][Test] Migrate all UT cases from jUnit 4 to 5 in common, service, and spi modules #12363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
EricGao888 merged 1 commit into from
Oct 14, 2022
Merged

[Migrate][Test] Migrate all UT cases from jUnit 4 to 5 in common, service, and spi modules #12363

EricGao888 merged 1 commit into from
Oct 14, 2022

Conversation

@DarkAssassinator
Copy link
Contributor

@DarkAssassinator DarkAssassinator commented Oct 13, 2022

Purpose of the pull request

Brief change log

  • Migrate all UT cases from jUnit 4 to 5 in common, service, and spi modules

Verify this pull request

  • Verified by UT cases.

@DarkAssassinator
Copy link
Contributor Author

DarkAssassinator commented Oct 13, 2022

@EricGao888 please help to review, thx

@EricGao888 EricGao888 added improvement make more easy to user or prompt friendly backend test labels Oct 13, 2022
@EricGao888 EricGao888 added this to the 3.2.0 milestone Oct 13, 2022
@github-actions github-actions bot removed the test label Oct 13, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 267 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@EricGao888 EricGao888 self-requested a review October 14, 2022 02:46
EricGao888
EricGao888 approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@EricGao888 EricGao888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EricGao888 EricGao888 merged commit b357781 into apache:dev Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EricGao888 EricGao888 EricGao888 approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

Assignees

@DarkAssassinator DarkAssassinator

Labels

backend improvement make more easy to user or prompt friendly

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

[Migrate ][Test] Migrate all UT cases from jUnit 4 to jUnit 5 in common, service and spi module

2 participants

@DarkAssassinator @EricGao888