[improvement] Migrate all UT cases from jUnit4 to jUnit5 in dao module #12328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
EricGao888
added
improvement
EricGao888
requested changes
Oct 12, 2022
dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/AlertDaoTest.java
Outdated
Show resolved
Hide resolved
...nscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/upgrade/WorkerGroupDaoTest.java
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...nscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/upgrade/WorkerGroupDaoTest.java
Fixed
Show fixed
Hide fixed
...nscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/upgrade/WorkerGroupDaoTest.java
Fixed
Show fixed
Hide fixed
Codecov Report
@@ Coverage Diff @@
## dev #12328 +/- ##
============================================
- Coverage 38.94% 38.92% -0.02%
+ Complexity 4178 4175 -3
============================================
Files 1040 1040
Lines 38797 38797
Branches 4460 4462 +2
============================================
- Hits 15109 15103 -6
- Misses 21919 21926 +7
+ Partials 1769 1768 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fuchanghai
force-pushed
the
improve-#12319
branch
from
9db9836 to
5481dc9
Compare
Member
|
Seems network problems, have rerun the failed CI. |
|
Kudos, SonarCloud Quality Gate passed!
|
xdu-chenrj
pushed a commit
to xdu-chenrj/dolphinscheduler
that referenced
this pull request
Oct 13, 2022
apache#12328) * [improvement] Migrate all UT cases from jUnit4 to jUnit5 in dao module Co-authored-by: Jackie <‘[email protected]’>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Brief change log
this close #12319