Skip to content

Conversation

@rickchengx
Copy link
Contributor

@rickchengx rickchengx commented Oct 10, 2022

Purpose of the pull request

Brief change log

update the conf.common in values.yaml, keeping it the same with dolphinscheduler-common/src/main/resources/common.properties

Verify this pull request

manually tested

截屏2022-10-10 14 17 59

kezhenxu94
kezhenxu94 previously approved these changes Oct 10, 2022
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

SbloodyS
SbloodyS previously approved these changes Oct 10, 2022
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SbloodyS SbloodyS added this to the 3.0.2 milestone Oct 10, 2022
@SbloodyS SbloodyS added improvement make more easy to user or prompt friendly backend labels Oct 10, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2022

Codecov Report

Merging #12290 (fbb6116) into dev (9ab79e0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev   #12290   +/-   ##
=========================================
  Coverage     38.53%   38.53%           
  Complexity     4075     4075           
=========================================
  Files          1023     1023           
  Lines         38267    38267           
  Branches       4393     4393           
=========================================
  Hits          14748    14748           
  Misses        21796    21796           
  Partials       1723     1723           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kezhenxu94 kezhenxu94 dismissed stale reviews from SbloodyS and themself via d34d190 October 10, 2022 07:38
@kezhenxu94
Copy link
Member

Rebased on the dev to have the mergeable check passed.

@github-actions github-actions bot removed the backend label Oct 10, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ruanwenjun ruanwenjun merged commit 6332fee into apache:dev Oct 12, 2022
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 13, 2022
@EricGao888 EricGao888 modified the milestones: 3.0.2, 3.2.0 Nov 7, 2022
fuchanghai pushed a commit to fuchanghai/dolphinscheduler that referenced this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement make more easy to user or prompt friendly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement][k8s] update the common.properties in values.yaml

6 participants