Skip to content

Conversation

@Amy0104
Copy link
Member

@Amy0104 Amy0104 commented Sep 30, 2022

Purpose of the pull request

This pull request sets the required to be reactive in the task modal.

Related Issue

close #12202
ref #11882

@Amy0104 Amy0104 added UI ui and front end related improvement make more easy to user or prompt friendly labels Sep 30, 2022
@Amy0104 Amy0104 self-assigned this Sep 30, 2022
@Amy0104 Amy0104 requested a review from songjianet as a code owner September 30, 2022 02:44
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2022

Codecov Report

Merging #12225 (a6b778a) into dev (db9db94) will increase coverage by 0.10%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #12225      +/-   ##
============================================
+ Coverage     39.45%   39.55%   +0.10%     
- Complexity     4139     4173      +34     
============================================
  Files          1011     1016       +5     
  Lines         37845    38090     +245     
  Branches       4347     4378      +31     
============================================
+ Hits          14930    15065     +135     
- Misses        21184    21284     +100     
- Partials       1731     1741      +10     
Impacted Files Coverage Δ
...r/plugin/task/sqoop/parameter/SqoopParameters.java 55.12% <0.00%> (-1.29%) ⬇️
...ache/dolphinscheduler/plugin/task/dms/DmsTask.java 52.74% <0.00%> (ø)
...lphinscheduler/plugin/task/dms/DmsTaskChannel.java 0.00% <0.00%> (ø)
...olphinscheduler/plugin/task/dms/DmsParameters.java 0.00% <0.00%> (ø)
...ache/dolphinscheduler/plugin/task/dms/DmsHook.java 63.30% <0.00%> (ø)
...heduler/plugin/task/dms/DmsTaskChannelFactory.java 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@labbomb labbomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@devosend devosend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement make more easy to user or prompt friendly UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement][UI] The required should be reactive in the task modal.

6 participants