Skip to content

Conversation

@boy-xiaozhang
Copy link
Contributor

@boy-xiaozhang boy-xiaozhang commented Sep 22, 2022

Purpose of the pull request

Fix error problem on h2 startup data quality rule management page

Brief change log

add h2 database keyword conflict resolve

Verify this pull request

add UT to [dolphinscheduler-dao]

join issue #12107

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2022

Codecov Report

Merging #12108 (5169320) into dev (b1b57c8) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev   #12108   +/-   ##
=========================================
  Coverage     38.70%   38.70%           
- Complexity     4007     4010    +3     
=========================================
  Files          1001     1001           
  Lines         37422    37422           
  Branches       4264     4262    -2     
=========================================
  Hits          14483    14483           
  Misses        21292    21292           
  Partials       1647     1647           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng added the bug Something isn't working label Oct 11, 2022
@caishunfeng caishunfeng added this to the 3.0.2 milestone Oct 11, 2022
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit 04e1b88 into apache:dev Oct 11, 2022
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 13, 2022
EricGao888 pushed a commit to EricGao888/dolphinscheduler that referenced this pull request Nov 7, 2022
EricGao888 added a commit that referenced this pull request Nov 7, 2022
fuchanghai pushed a commit to fuchanghai/dolphinscheduler that referenced this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants