Search before asking

• I had searched in the issues and found no similar feature requirement.

Description

• This is part of DSIP-10 [DSIP-10][Unit Tests] Improve DolphinScheduler unit tests #10573

• By this moment, we have added jUnit 5 dependencies [Improvement][UT] Upgrade jUnit to 5.+ (#10976) #11332 and removed all Powermock related code [Improvement][Test] Remove dependency of powermock #11405. It is high time that we migrate all the UT cases from jUnit 4 to jUnit 5 and remove the dependency of junit-vintage-engine so that there will be one and only one version of unit test cases, which is jUnit5, in the whole project.

SOP

These two following articles are recommended for you to understand the whole process. In order to keep the instructions brief and concise, I summarize some key points of these two articles as well as add a few extra operations based on practice for your reference:

• https://blogs.oracle.com/javamagazine/post/migrating-from-junit-4-to-junit-5-important-differences-and-benefits
• https://blog.jetbrains.com/idea/2020/08/migrating-from-junit-4-to-junit-5/

BTW, I suggest you perform this SOP below by module or by file, instead of doing it for the whole project. This helps you increase efficiency.

1. Perform basic migration through Intellij IDE for the module you choose.
   
2. Replace @RunWith(MockitoJUnitRunner.class) with @ExtendWith(MockitoExtension.class) if necessary.
3. Replace Assert with Assertions.
4. Fix expected exception if necessary.

// jUnit 4
@Test(expected = Exception.class)
public void testThrowsException() throws Exception {
    // ...
}

// jUnit 5
@Test
public void testThrowsException() throws Exception {
    Assertions.assertThrows(Exception.class, () -> {
        //...
    });
}

6. Fix timeout if necessary.

// jUnit 4
@Test(timeout = 10)
public void testFailWithTimeout() throws InterruptedException {
    Thread.sleep(100);
}

// jUnit 5
@Test
void testFailWithTimeout() throws InterruptedException {
    Assertions.assertTimeout(Duration.ofMillis(10), () -> Thread.sleep(100));
}

Assertions.assertTimeout(Duration.ofMillis(60000), () -> {});

8. Replace @Ignore with @Disable if necessary.
9. Replace org.junit.rules.TemporaryFolder with org.junit.jupiter.api.io.TempDir and use @TempDir if necessary.
10. Run the UT file you changed to see whether all cases pass successfully.
11. Fix unnecessary stubbings if necessary. This is caused by changing @Before into @BeforeEach. The recommend method is to use @MockitoSettings(strictness = Strictness.LENIENT). Alternatively, you could either remove the unnecessary stubbings from @BeforeEach and only put them where they needed or use Mockito.lenient().when(...... for Mockito.when(...... to bypass the stubbing check.
12. Global search in your module and make sure all org.junit.xxxx has been migrated to org.junit.jupiter.api.xxx

PR Example

• [Improvement][Test] Migrate all UT cases from jUnit4 to jUnit5 in task-plugin module as an example #12299

Sub-Tasks

We hope to complete all the following sub-tasks before Oct. 25th because DSIP-10 depends on this issue and all UT cases are supposed to be migrated to jUnit 5 before the start of UT refactoring.

• Migrate all UT cases from jUnit 4 to jUnit 5 in task-plugin module: [Improvement][Test] Migrate all UT cases from jUnit4 to jUnit5 in task-plugin module as an example #12299
• Migrate all UT cases from jUnit 4 to jUnit 5 in alert and api module: [Migration][Test] Migrate all UT cases from jUnit 4 to jUnit 5 in alert and api module #12313
• Migrate all UT cases from jUnit 4 to jUnit 5 in dao module: Migrate all UT cases from jUnit 4 to jUnit 5 in dao module #12319
• Migrate all UT cases from jUnit 4 to jUnit 5 in data-quality, datasource-plugin and registry module: [Migrate][Test] Migrate all UT cases from jUnit 4 to jUnit 5 in data-quality, datasource-plugin and registry module #12322
• Migrate all UT cases from jUnit 4 to jUnit 5 in master, worker and remote module: [Migration][Test] Migrate all UT cases from jUnit 4 to jUnit 5 in master, worker and remote module #12316
• Migrate all UT cases from jUnit 4 to jUnit 5 in common, service and spi module: [Migrate ][Test] Migrate all UT cases from jUnit 4 to jUnit 5 in common, service and spi module #12317
• Migrate all UT cases from jUnit 4 to jUnit 5 in microbench and e2e module: [Migration][Test] Migrate all UT cases from jUnit 4 to jUnit 5 in microbench and e2e module #12333
• Block explicit imports of jUnit 4 library. [Migrate][Test] Block explicit import of jUnit 4 library #12395

Are you willing to submit a PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct