-
Notifications
You must be signed in to change notification settings - Fork 5k
Closed
Labels
Description
Search before asking
- I had searched in the issues and found no similar issues.
What happened
When try to create PRESTO datasource type, if jdbc connect parameters assigned.
TestConnect will be failed with tips "JDBC connect failed".
For example, use {"SSL":"true"} as connect params:

the logs will shows:
[ERROR] 2022-09-01 11:38:21.728 +0800 com.zaxxer.hikari.pool.HikariPool:[594] - HikariPool-2 - Exception during pool initialization.
java.sql.SQLException: Connection property 'SSL' is both in the URL and an argument
What you expected to happen
Because "SSL" is a valid property when connect presto, so the test connect should be success.
How to reproduce
As above.
Two points mentioned:
- plz just use jdbc connet params at first to avoid the dataSourceClientCache, bcz cache key does not contain params.
- IMO, when connect presto, we can set params either in jdbc-url or properties, However, the same parameter may not be specified using both methods, ref to JDBC driver
I'm pleasure to fix this, and what is next?
Anything else
Every time happens.
Version
3.0.0
Are you willing to submit PR?
- Yes I am willing to submit a PR!
Code of Conduct
- I agree to follow this project's Code of Conduct