Skip to content

[Bug] [dolphinscheduler-api] create presto datasource failed with extra "jdbc connect parameters" #11726

@izualzhy

Description

@izualzhy

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

When try to create PRESTO datasource type, if jdbc connect parameters assigned.
TestConnect will be failed with tips "JDBC connect failed".

For example, use {"SSL":"true"} as connect params:
image

the logs will shows:

[ERROR] 2022-09-01 11:38:21.728 +0800 com.zaxxer.hikari.pool.HikariPool:[594] - HikariPool-2 - Exception during pool initialization.
java.sql.SQLException: Connection property 'SSL' is both in the URL and an argument

What you expected to happen

Because "SSL" is a valid property when connect presto, so the test connect should be success.

How to reproduce

As above.
Two points mentioned:

  1. plz just use jdbc connet params at first to avoid the dataSourceClientCache, bcz cache key does not contain params.
  2. IMO, when connect presto, we can set params either in jdbc-url or properties, However, the same parameter may not be specified using both methods, ref to JDBC driver
    I'm pleasure to fix this, and what is next?

Anything else

Every time happens.

Version

3.0.0

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Metadata

Metadata

Assignees

Labels

backendbugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions