resolve NumberFormatException

cloudzzz996 · cloudzzz996 · commit 88845f888dfb · 2022-11-21T18:09:42.000+08:00
diff --git a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-trino/src/main/java/org/apache/dolphinscheduler/plugin/datasource/trino/param/TrinoDataSourceProcessor.java b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-trino/src/main/java/org/apache/dolphinscheduler/plugin/datasource/trino/param/TrinoDataSourceProcessor.java
@@ -57,10 +57,9 @@ public BaseDataSourceParamDTO createDatasourceParamDTO(String connectionJson) {
         String[] hostPortArray = hostSeperator[hostSeperator.length - 1].split(Constants.COMMA);
 
         TrinoDataSourceParamDTO TrinoDatasourceParamDTO = new TrinoDataSourceParamDTO();
-        if (isNumeric(hostPortArray[0].split(Constants.COLON)[1])) {
-            TrinoDatasourceParamDTO.setPort(Integer.valueOf(hostPortArray[0].split(Constants.COLON)[1]));
-        }
-        TrinoDatasourceParamDTO.setHost(hostPortArray[0].split(Constants.COLON)[0]);
+        String[] split = hostPortArray[0].split(Constants.COLON);
+        TrinoDatasourceParamDTO.setHost(split[0]);
+        TrinoDatasourceParamDTO.setPort(Integer.valueOf(split[1]));
         TrinoDatasourceParamDTO.setDatabase(connectionParams.getDatabase());
         TrinoDatasourceParamDTO.setUserName(connectionParams.getUser());
         TrinoDatasourceParamDTO.setOther(parseOther(connectionParams.getOther()));
@@ -151,11 +150,4 @@ private Map<String, String> parseOther(String other) {
         }
         return otherMap;
     }
-    public boolean isNumeric(String str) {
-        if (str != null && !"".equals(str.trim())) {
-            return str.matches("^[0-9]*$");
-        } else {
-            return false;
-        }
-    }
 }
