Skip to content

JaccardSimilarity#jaccard can throw #153

New issue
New issue
Closed
Closed
JaccardSimilarity#jaccard can throw#153

Description

@hpx7
hpx7
opened on Jun 15, 2017

See https://github.com/DataSketches/sketches-core/blob/master/src/main/java/com/yahoo/sketches/theta/JaccardSimilarity.java#L46

This fails if ceilingPowerOf2(countA + countB)) is not between the accepted range for nominal entires.

I'm happy to submit a PR with the fix + test, but didn't see any contribution guidelines.

Activity

  1. leerho commented on Jun 16, 2017

    @leerho
    leerho
    on Jun 16, 2017
    Member

    Thank you for finding this. It will be fixed in the next release, which is coming (hopefully) in the next few days. It is fixed on master.

  2. leerho
    closed this as completedon Jun 16, 2017
  3. leerho
    added a commit that references this issue on Oct 27, 2026

    Theta: clamp the union size in JaccardSimilarity.exactlyEqual

    0ebe894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions