Add IS NOT TRUE, IS NOT FALSE, and IS [NOT] UNKNOWN#583
Merged
andygrove merged 1 commit intoapache:mainfrom Aug 18, 2022
sarahyurick:main
Merged
Add IS NOT TRUE, IS NOT FALSE, and IS [NOT] UNKNOWN#583andygrove merged 1 commit intoapache:mainfrom sarahyurick:main
IS NOT TRUE, IS NOT FALSE, and IS [NOT] UNKNOWN#583andygrove merged 1 commit intoapache:mainfrom
sarahyurick:main
Conversation
andygrove
approved these changes
Aug 17, 2022
Member
andygrove
left a comment
andygrove
left a comment
There was a problem hiding this comment.
Thanks @sarahyurick. This seems to follow the pattern we use for other IS expressions such as IsNull / IsNotNull, so LGTM.
Member
|
Link to Postgres documentation on these expressions for anyone interested: |
Pull Request Test Coverage Report for Build 2878598801
💛 - Coveralls |
This was referenced Aug 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #582
Previously, sqlparser did not support "is not true," "is not false," "is unknown," and "is not unknown," so I have added them here.