Merged
Conversation
Pull Request Test Coverage Report for Build 2829377994
💛 - Coveralls |
alamb
approved these changes
Aug 11, 2022
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @MazterQyou -- we are on a roll today!
| Ok(None) | ||
| } else { | ||
| Ok(Some(Expr::Value(self.parse_number_value()?))) | ||
| Ok(Some(self.parse_expr()?)) |
mcheshkov
pushed a commit
to cube-js/sqlparser-rs
that referenced
this pull request
Sep 2, 2024
Can drop this after rebase on commit 8176561 "Support expressions in LIMIT/OFFSET (apache#567)", first released in 0.21.0
mcheshkov
pushed a commit
to cube-js/sqlparser-rs
that referenced
this pull request
Sep 2, 2024
Can leave only test after rebase on commit 8176561 "Support expressions in LIMIT/OFFSET (apache#567)", first released in 0.21.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LIMITandOFFSETallow usage of complex expressions, such as1+2, or placeholders for prepared statements, whereas sqlparser only accepts numbers. This PR adds support for any kind of expression inLIMITandOFFSET, and adds related tests.