Skip to content

Comments

Support SHOW COLUMNS FROM tbl FROM db#562

Merged
alamb merged 1 commit intoapache:mainfrom
cube-js:upstream-patch/show-columns-from-from
Aug 11, 2022
Merged

Support SHOW COLUMNS FROM tbl FROM db#562
alamb merged 1 commit intoapache:mainfrom
cube-js:upstream-patch/show-columns-from-from

Conversation

@MazterQyou
Copy link
Contributor

This PR adds support for SHOW COLUMNS FROM tbl [FROM db] alternative MySQL syntax. Previously only SHOW COLUMNS FROM [db.]tbl syntax was supported.
There are no changes to AST, so no breakage for dependents is expected.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2826165415

  • 8 of 9 (88.89%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 89.958%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser.rs 7 8 87.5%
Totals Coverage Status
Change from base Build 2805421159: 0.006%
Covered Lines: 9102
Relevant Lines: 10118

💛 - Coveralls

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @MazterQyou

Ok(val) => panic!("unexpected successful parse: {:?}", val),
}
mysql_and_generic().one_statement_parses_to(
"SHOW COLUMNS FROM mytable FROM mydb",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alamb alamb merged commit 71c3ec0 into apache:main Aug 11, 2022
@MazterQyou MazterQyou deleted the upstream-patch/show-columns-from-from branch August 11, 2022 11:06
mcheshkov pushed a commit to cube-js/sqlparser-rs that referenced this pull request Sep 2, 2024
* feat: Support SHOW COLUMNS FROM tbl FROM db

* Fix formatting in SHOW COLUMNS

Can drop this after rebase on commit 71c3ec0 "Support SHOW COLUMNS FROM tbl FROM db (apache#562)", first released in 0.21.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants