Support prepared statement placeholder arg ? and $#420
Merged
alamb merged 1 commit intoapache:mainfrom Feb 17, 2022
Merged
Conversation
houqp
approved these changes
Feb 11, 2022
Pull Request Test Coverage Report for Build 1827316036Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
alamb
reviewed
Feb 16, 2022
| }, | ||
| /// `NULL` value | ||
| Null, | ||
| /// `?` or `$` Prepared statement arg placeholder |
Contributor
There was a problem hiding this comment.
I am not familiar with the $ syntax for prepared argument placeholders. What database system do they come from?
I have only ever seen ? used for prepared statement placeholders
Contributor
Author
There was a problem hiding this comment.
Here is an example from pgsql's document.
PREPARE fooplan (int, text, bool, numeric) AS
INSERT INTO foo VALUES($1, $2, $3, $4);
EXECUTE fooplan(1, 'Hunter Valley', 't', 200.00);However, only numbers follow the $.
Then I found that there was a need for $foo in the issue. #145 (comment)
So the final product is this:
SELECT * FROM student WHERE id = $Id1;Maybe there can't be a separate $placeholder here.
Thank you even more for your continued contribution. I'm just a spoon of water in the ocean :-)
alamb
changed the title
?
alamb
changed the title
??
alamb
changed the title
?? and $
alamb
approved these changes
Feb 17, 2022
ovr
pushed a commit
to cube-js/sqlparser-rs
that referenced
this pull request
Mar 28, 2022
Co-authored-by: gamife <[email protected]>
ovr
pushed a commit
to cube-js/sqlparser-rs
that referenced
this pull request
Apr 14, 2023
Co-authored-by: gamife <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#145 support
?or$fooprepared statement arg placeholder.