Support array expressions such as ARRAY[1,2] , foo[1] and INT[][]#419
Merged
alamb merged 2 commits intoapache:mainfrom Feb 17, 2022
Merged
Support array expressions such as ARRAY[1,2] , foo[1] and INT[][]#419alamb merged 2 commits intoapache:mainfrom
ARRAY[1,2] , foo[1] and INT[][]#419alamb merged 2 commits intoapache:mainfrom
Conversation
Pull Request Test Coverage Report for Build 1856868780
💛 - Coveralls |
alamb
reviewed
Feb 16, 2022
| expr: Box::new(expr), | ||
| }) | ||
| } else if Token::LBracket == tok { | ||
| if dialect_of!(self is PostgreSqlDialect) { |
Contributor
There was a problem hiding this comment.
| } | ||
|
|
||
| #[test] | ||
| fn parse_map_access_expr() { |
Contributor
There was a problem hiding this comment.
Could you please add back the the existing test parsing the simpler expression SELECT foo[0] FROM foos to make sure that that syntax is still supported (it would be fine if the resulting parse tree is slightly different)
I think it is important to ensure that this PR does not introduce a regression in terms of the syntax that is supported (I don't think it does, but I would like the test to ensure that this is the case)
Contributor
Author
There was a problem hiding this comment.
Ok. Thanks for the review!
alamb
changed the title
ARRAY[1,2] , foo[1] and INT[][]
alamb
changed the title
ARRAY[1,2] , foo[1] and INT[][]ARRAY[1,2] , foo[1] and INT[][]
alamb
approved these changes
Feb 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.