Add identifier quote style to Dialect trait#1170
Merged
alamb merged 2 commits intoapache:mainfrom Mar 11, 2024
Merged
Conversation
Contributor
Author
|
cc @alamb |
5 tasks
Contributor
|
Looks good to me -- thank you @backkem I think before we could merge this PR we need some tests ( mostly so if it got broken by accident in the future we would know because a test would fail) |
Pull Request Test Coverage Report for Build 8238316231Details
💛 - Coveralls |
Contributor
Author
|
I added a basic test. It feels somewhat artificial but I didn't want to build additional 'unparser' logic in the test case. |
alamb
approved these changes
Mar 11, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
I added a basic test. It feels somewhat artificial but I didn't want to build additional 'unparser' logic in the test case.
I agree it feels somewhat forced, but I think that is also OK in this case. We can improve things later if necessary.
Thank you @backkem
alamb
changed the title
alamb
changed the title
Dialect trait
5 tasks
lustefaniak
pushed a commit
to getsynq/sqlparser-rs
that referenced
this pull request
Apr 10, 2024
(cherry picked from commit 929c646)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to apache/datafusion#9517 where we're adding an SQL
unparserto turn DataFusion Expr/Plans back into SQL.I extended the method to allow passing the identifier value. This may be helpful in case we want to add heuristics to only add quotes if truly needed by the dialect.