Skip to content

A bracket-quoted identifier containing ]] round-trips to SQL that fails to reparse #2409

Open

Description

@DRMacIver
use sqlparser::dialect::MsSqlDialect;
use sqlparser::parser::Parser;

fn main() {
    let sql = "SELECT [a]]b]";
    let ast = Parser::parse_sql(&MsSqlDialect {}, sql).unwrap();
    let printed = ast[0].to_string();
    println!("input:    {}", sql);
    println!("printed:  {}", printed);
    let reparsed = Parser::parse_sql(&MsSqlDialect {}, &printed);
    println!("reparsed: {:?}", reparsed);
}
input:    SELECT [a]]b]
printed:  SELECT [a]b]
reparsed: Err(ParserError("Expected: end of statement, found: ] at Line: 1, Column: 12"))

[a]]b] is a bracket-quoted identifier whose value is a]b (the tokenizer folds the doubled ]] into a literal ]). Displaying the parsed AST back to SQL writes [a]b] instead, and that string does not parse as the same identifier: it parses as a followed by leftover tokens ]b].

Tested on sqlparser 0.62.0.

BTW, this bug was found using hegel. Happy to contribute the tests if you're interested.

Activity

  1. hdimer commented on Jul 30, 2026

    @hdimer

    Confirmed on main. One wrinkle worth flagging: the fix can't just double ] unconditionally, because Redshift also parses nested quoted identifiers like ["a]b"] where the value is stored as the complete double-quoted string "a]b" and the inner ] is literal (doubling it would break that round-trip). The AST doesn't distinguish the two forms, so I double ] only when the value isn't a complete "..." string. Opened #2418.

  2. added a commit that references this issue on Sep 24, 2026
    77b71e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions