Conversation
timsaucer
force-pushed
the
site/adjust-relative-url
branch
from
c1dfa2a to
57068dc
Compare
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @timsaucer ! I tested this out and it works great ❤️
However, I think it is important to note that the staging workflow only works from branches in the main repo (not forks).
When I made a PR from a branch in my own fork
The CI job fails with 403 error: https://github.com/apache/datafusion-site/actions/runs/12212614636/job/34071269677?pr=46
When I made a branch in this repo
Then the CI job completes successfully 🎉
https://github.com/apache/datafusion-site/actions/runs/12212614636/job/34071269677?pr=46
| ARTICLE_URL = 'blog/{date:%Y}/{date:%m}/{date:%d}/{filename}' | ||
| ARTICLE_SAVE_AS = 'blog/{date:%Y}/{date:%m}/{date:%d}/{filename}/index.html' | ||
| # needed to create blogs page. Do not put the preceeding /blog here because | ||
| # that will be added by asf infra when it posts the site |
There was a problem hiding this comment.
Maybe it is also worth noting here we use this url scheme to preserve old links
| # that will be added by asf infra when it posts the site | |
| # (Use this particular URL scheme to maintain link compatibility with older versions of this site) |
| `asf-staging`. Once this completes, the ASF infrastructure will auto publish | ||
| this staged branch to https://datafusion.staged.apache.org/ | ||
|
|
||
| The most recently run staging CI pipeline will be published to this site. If you |
There was a problem hiding this comment.
I tested it out and I think this workflow doesn't work for forks -- see review comments
| The most recently run staging CI pipeline will be published to this site. If you | |
| This workflow only works for branches in this repository (not for forks). | |
| In order to use https://datafusion.staged.apache.org/ you need to be a committer | |
| and create the branch directly in this repository. | |
| The most recently run staging CI pipeline will be published to this site. If you |
… the main repo, not on branches of forks
3 participants
This PR is designed to set the built site to be relative to the /blog directory since ASF infra puts it there for the urls. I also updated the README to show how to use the staged blog to preview.
After merging I'll do the final step, which is to remove the old site content from the
asf-sitebranch and test it. If that breaks for any reason, I'll revert the commit on that branch.Closes #13