Repository navigation
Conversation
tpchgen-cli 4.0.0 moved the output format to a subcommand and removed the --format flag, so the unpinned install made `tpchgen-cli -s 1 --format=parquet` fail with "unexpected argument '--format'". Use `tpchgen-cli parquet -s 1` and pin to 4.x so a future major release cannot break the TPC-H step silently. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A. Found while testing the DataFusion 56 upgrade (#1826).
Rationale for this change
tpchgen-cli4.0.0 (released 2026-10-19) moved the output format to a subcommand and removed the--formatflag. The test workflow installstpchgen-cliunpinned and runstpchgen-cli -s 1 --format=parquet, which now fails:No
abi3test job has reached this step since that release. On #1826 it was skipped only because an earlier step failed, so it goes red as soon as that is fixed, and the same applies to any other PR.What changes are included in this PR?
In
.github/workflows/test.yml:tpchgen-cli -s 1 --format=parquetbecomestpchgen-cli parquet -s 1.tpchgen-cli>=4,<5, so a future major release can't break the step without a deliberate bump.The 4.x default output (one
<table>.parquetper table in the current directory) is the same layoutexamples/tpchreads. I checked this locally: data generated withtpchgen-cli parquet -s 1passes all 22 TPC-H tests (pytest examples/tpch/_tests.py).Are there any user-facing changes?
No. CI only.
🤖 Generated with Claude Code