Repository navigation
Commit fd04863
Cover RoundRobinBatch, stop claiming a plan can report Range
The `scheme` docstring listed four values as though a plan could report any
of them. Two of the four needed opposite corrections.
`RoundRobinBatch` is reachable, and now tested. It is easy to miss because
it never survives at the root: the optimizer inserts one only above a source
with fewer partitions than `target_partitions` and CPU work above it to
parallelize, so a single-file Parquet scan under a filter and a grouped
aggregate produces `RepartitionExec: partitioning=RoundRobinBatch(8)` three
levels down. The test walks `children` and asserts all three schemes in that
tree, which also pins that the accessor reads each node's own partitioning
rather than the root's.
`Range` is the other way: it is in the upstream enum, but nothing constructs
one in a physical plan. `RangePartitioning` says optimizer and execution
support is deliberately unimplemented, per
apache/datafusion#22395. Say so, and say why the match arm exists anyway --
it keeps this getter compiling when that support lands, and dropping it
would make the match non-exhaustive.
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>1 parent baf828f commit fd04863
3 files changed
Lines changed: 40 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
158 | 158 | | |
159 | 159 | | |
160 | 160 | | |
161 | | - | |
162 | 161 | | |
163 | 162 | | |
164 | | - | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
165 | 171 | | |
166 | 172 | | |
167 | 173 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
346 | 346 | | |
347 | 347 | | |
348 | 348 | | |
349 | | - | |
350 | | - | |
351 | | - | |
352 | | - | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
353 | 354 | | |
354 | 355 | | |
355 | 356 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| |||
144 | 145 | | |
145 | 146 | | |
146 | 147 | | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
147 | 174 | | |
148 | 175 | | |
149 | 176 | | |
| |||
0 commit comments