Repository navigation
Commit 846fe6e
Link the upstream FFI issue, stop teaching execute by counter-example
The `ForeignExecutionPlan` arm's comment explained the symptom but left the
reader no way to find out whether the workaround is still needed. Name the
upstream umbrella issue, apache/datafusion#25152, and the cascade behind it:
`FFI_PlanProperties` carries no `scheduling_type`, so `EnsureCooperative`
reads every foreign leaf as non-cooperative and wraps it, and the resulting
`ForeignExecutionPlan` then cannot serialize itself. Fixing either half
retires the arm.
Drop the out-of-range call from `SessionContext.execute`'s doctest. A
docstring example shows a reader how to use the method, and this one put a
wrong call in front of them; the message it asserted is already pinned by
`test_execute_rejects_an_out_of_range_partition`. The `Raises:` section is
the right home for that behaviour, so complete it: a negative or oversized
index raises `OverflowError` from the `usize` conversion, not the
`ValueError` the bounds check produces.
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>1 parent 4c097c7 commit 846fe6e
2 files changed
Lines changed: 9 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
143 | 150 | | |
144 | 151 | | |
145 | 152 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2364 | 2364 | | |
2365 | 2365 | | |
2366 | 2366 | | |
| 2367 | + | |
| 2368 | + | |
2367 | 2369 | | |
2368 | 2370 | | |
2369 | 2371 | | |
| |||
2382 | 2384 | | |
2383 | 2385 | | |
2384 | 2386 | | |
2385 | | - | |
2386 | | - | |
2387 | | - | |
2388 | 2387 | | |
2389 | 2388 | | |
2390 | 2389 | | |
| |||
0 commit comments