Repository navigation
Conversation
Co-authored-by: Codex <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4329.
Supersedes #5358 after #7521 removed the Spark 3.4 build profile and CI coverage and #7560 removed the Spark 3.4 shim source sets.
Rationale for this change
Spark 3.4 is no longer a supported build target, but compatibility branches, fallbacks, tests, generated diffs, and version-specific test assets remained in the codebase. Keeping those dead paths makes the supported Spark 3.5 and 4.x implementations harder to follow and maintain.
The separately tracked
get_json_object_spark34behavior is intentionally preserved.What changes are included in this PR?
CometExec3_4PlusSuitetoCometExecCompatibilitySuiteand update CI suite lists and active comments to describe the supported versions.How are these changes tested?
./mvnw -Pspark-3.5 -DskipTests test-compile./mvnw -Pspark-4.0 -DskipTests test-compile./mvnw -Pspark-4.1 -DskipTests test-compile./mvnw -Pspark-4.2 -DskipTests test-compilepython3 dev/ci/check-ci-config.pypython3 dev/ci/check-versioned-source-parity.pypython3 dev/ci/check-suites.pygit diff --checkThe focused Spark 3.5 SQL parser and plan-stability suites compiled locally, but the runner could not start because no compatible Spark 3.5 checkout is configured in
SPARK_HOMEorspark.test.home. Therun-spark-3.5-testslabel is requested for hosted validation.