Repository navigation
Conversation
github-actions
Bot
added
bug
…writes work on 1.12 Iceberg 1.12 removed the public ManifestFiles.read(ManifestFile, FileIO) overload, so the executor-side reflection probe failed and every native Iceberg write fell back to iceberg-java. The three-argument overload (manifest, io, specsById) is public on every supported version (1.5.2 through 1.12), so resolve that and pass the table's PartitionSpec for the stamped spec id. DetectionDelegatingFileIO moves to Java: HadoopConfigurable.getConf is abstract on some supported versions and a default method on 1.12, and Scala has no spelling that compiles against both.
Add dev/diffs/iceberg/1.12.0.diff, ported from the 1.11.0 diff and regenerated against the apache-iceberg-1.12.0 tag, and an iceberg_1_12 job in the nightly tier and behind the run-iceberg-tests label. Spark 4.2 support is still experimental, so it does not join the merge queue.
…ays on the 4.0 runtime Iceberg 1.12.0 has a Spark 4.2 module in source, but its release script only publishes the 3.5, 4.0 and 4.1 runtimes, so iceberg-spark-runtime-4.2 does not exist on Maven Central.
andygrove
force-pushed
the
iceberg-1-12-support
branch
from
November 11, 2026 18:47
0db2646 to
439104f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7240.
Part of #7493. The first item there (pointing the
spark-4.2profile aticeberg-spark-runtime-4.2_2.13:1.12.0) is not done, see below.Rationale for this change
Iceberg 1.12 removed the public two-argument
ManifestFiles.read(ManifestFile, FileIO), so every native Iceberg write silently fell back to iceberg-java. No CI job covered 1.12, so nothing caught it.The Spark 4.2 runtime that #7493 wants the profile to use does not exist: Iceberg 1.12.0 has a
spark/v4.2module in source, butdev/stage-binaries.shat the release tag publishesSPARK_VERSIONS=3.5,4.0,4.1only, andiceberg-spark-runtime-4.2_2.13:1.12.0does not resolve from Maven Central. Thespark-4.2profile therefore stays on the 4.0 runtime, and the!isSpark42Plusguards and the #4969 test stay as they are, until a release publishes it.What changes are included in this PR?
One commit per part:
ManifestFiles.read(manifest, io, specsById), public on every supported version (1.5.2 through 1.12), replaces the two-argument form in the executor probe and in the manifest decode. The decode passes the table'sPartitionSpecfor the stamped spec id.DetectionDelegatingFileIOmoves to Java becauseHadoopConfigurable.getConfis abstract on some supported versions and a default method on 1.12, which Scala cannot spell for both.dev/diffs/iceberg/1.12.0.diff, ported from the 1.11.0 diff and regenerated against theapache-iceberg-1.12.0tag (v4.1becomesv4.2; the session builder in the compaction benchmark moved toIcebergCompactionBenchmark), and aniceberg_1_12job running Iceberg 1.12.0 on Spark 4.2.0. It is nightly plus therun-iceberg-testslabel, because Spark 4.2 support is still experimental.ci.yml,compute-changes.py,check-ci-config.pyand the workflows README are updated.iceberg-spark-tests.md,iceberg-writes.md,ci.md, the Iceberg user guide, and aspark/pom.xmlcomment recording why the 4.2 runtime is not used.How are these changes tested?
CometIcebergRewriteActionSuite,CometIcebergWriteActionSuiteandCometIcebergWriteDetectionSuitepass on the default Iceberg 1.11 (206 of 206).GenericAppenderFactory, which the 1.12 runtime jar does not bundle, andfall-back: format-version=4now needs an absolute table location.RESTCatalogAdapter.javaalso does not compile against 1.12 (RESTUtil.NAMESPACE_SPLITTER,CatalogHandlers.loadTableandRESTUtil.decodeNamespacechanged). These need fixing when a profile moves to 1.12.apache-iceberg-1.12.0tag. With Comet installed for Spark 4.2,TestFilterPushDown(42 tests) andTestRewriteDataFilesAction(195 tests, 8 skipped) pass on Iceberg 1.12.0 and Spark 4.2.0 with no failures. The fulliceberg_1_12job has not run yet.python3 dev/ci/check-ci-config.pypasses.