Repository navigation
chore: Convert Rust project into a workspace - #637
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #637 +/- ##
============================================
+ Coverage 33.42% 33.54% +0.12%
- Complexity 805 823 +18
============================================
Files 109 109
Lines 42462 42512 +50
Branches 9342 9346 +4
============================================
+ Hits 14191 14262 +71
+ Misses 25322 25316 -6
+ Partials 2949 2934 -15 ☔ View full report in Codecov by Sentry. |
andygrove
marked this pull request as ready for review
July 6, 2024 14:33
viirya
approved these changes
Jul 6, 2024
This was referenced Jul 6, 2024
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
* convert into workspace project * update GitHub actions * update Makefile * fix regression * update target path * update protobuf path in pom.xml * update more paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This is a first step towards splitting the Comet code into multiple crates, such as a
datafusion-spark-exprcrate as suggested in #630Rationale for this change
There are multiple benefits to splitting the project into multiple crates
What changes are included in this PR?
coretonative/corenativeHow are these changes tested?