Conversation
rust-toolchain
Outdated
| @@ -1 +1 @@ | |||
| nightly-2023-09-05 | |||
| 1.77 | |||
There was a problem hiding this comment.
I will file a separate issue for upgrading to 1.78. We will need to fix some assumptions in our unsafe code first.
There was a problem hiding this comment.
Will this use 1.77.2 automatically? Looks like there are few fixes
There was a problem hiding this comment.
I updated this to 1.77.2
rust-toolchain
Outdated
| @@ -1 +1 @@ | |||
| nightly-2023-09-05 | |||
| 1.77 | |||
There was a problem hiding this comment.
Will this use 1.77.2 automatically? Looks like there are few fixes
|
|
||
| /// A mutable vector that can be re-used across batches. | ||
| #[derive(Debug)] | ||
| pub struct MutableVector { |
There was a problem hiding this comment.
@sunchao Removed this in the original PR that I forked from.
There was a problem hiding this comment.
Yes we don't need this anymore. It was created originally to facilitate Comet specific data types, vectors and kernels (for instance leveraging array view), but we've decided to fully use DataFusion now.
sunchao
left a comment
sunchao
left a comment
There was a problem hiding this comment.
LGTM, thanks @andygrove for taking this over!
advancedxy
left a comment
advancedxy
left a comment
There was a problem hiding this comment.
LGTM. Thanks for taking this over. I was about to ask chao if he is still working on the #373.
It looks like the CI is still failed, you may take a look at that:
- unary negative integer overflow test *** FAILED *** (817 milliseconds)
"[ARITHMETIC_OVERFLOW] short overflow. If necessary set "spark.sql.ansi.enabled" to "false" to bypass this error. SQLSTATE: 22003" did not contain " caused overflow" (CometExpressionSuite.scala:1563)
It looks like the unary minus tests are failing in main as well for Spark 4. I think there was a conflict between two PRs that were merged yesterday. |
* initial commit * change github workflow * try to use stable rustfmt * update CI * lint * CI * clippy * clippy * ignore some tests * remove more nightly references * add some assertions to make code safe * revert a change * use Rust 1.77 * specify rust version 1.77.2 * fix CI --------- Co-authored-by: Chao Sun <[email protected]>
5 participants
Which issue does this PR close?
Closes #142
Rationale for this change
Continues the work started by @sunchao in #373
What changes are included in this PR?
How are these changes tested?