feat: add partial support for date_format expression#3201
Merged
andygrove merged 4 commits intoapache:mainfrom Jan 19, 2026
Merged
feat: add partial support for date_format expression#3201andygrove merged 4 commits intoapache:mainfrom
andygrove merged 4 commits intoapache:mainfrom
Conversation
Adds native Comet support for Spark's `date_format` function using DataFusion's `to_char` function. Supports a whitelist of common format strings that can be reliably mapped between Spark SimpleDateFormat patterns and strftime patterns. Supported formats include: - yyyy-MM-dd, yyyy/MM/dd (date formats) - HH:mm:ss, HH:mm (time formats) - yyyy-MM-dd HH:mm:ss (datetime formats) - EEEE, EEE, MMMM, MMM (day/month names) - hh:mm:ss a, hh:mm a, h:mm a (12-hour time) - yyyy-MM-dd'T'HH:mm:ss (ISO format) Closes apache#3088 Co-Authored-By: Claude Opus 4.5 <[email protected]>
Adds tests to verify date_format behavior with non-UTC timezones: - Non-UTC timezones are marked as Incompatible and fall back to Spark - Users can enable with spark.comet.expr.DateFormatClass.allowIncompatible=true Co-Authored-By: Claude Opus 4.5 <[email protected]>
andygrove
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3201 +/- ##
============================================
+ Coverage 56.12% 60.04% +3.91%
- Complexity 976 1429 +453
============================================
Files 119 170 +51
Lines 11743 15760 +4017
Branches 2251 2603 +352
============================================
+ Hits 6591 9463 +2872
- Misses 4012 4977 +965
- Partials 1140 1320 +180 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Thanks @andygrove ,LGTM, please resolve conflicts. |
wForget
approved these changes
Jan 19, 2026
Member
Author
|
Thanks for the review @wForget |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
date_formatfunctionto_charfunction for the underlying implementationSupported formats include:
yyyy-MM-dd,yyyy/MM/dd,yyyyMMdd,yyyyMMHH:mm:ss,HH:mm,HH,mm,ssyyyy-MM-dd HH:mm:ss,yyyy/MM/dd HH:mm:ssEEEE,EEE,MMMM,MMMhh:mm:ss a,hh:mm a,h:mm ayyyy-MM-dd'T'HH:mm:ssyyyy,yy,MM,ddUnsupported format strings will fall back to Spark execution.
Timezone Support
Currently only UTC timezone is fully compatible. Non-UTC timezones are marked as
Incompatibleand fall back to Spark by default. Users can enable Comet execution for non-UTC timezones withspark.comet.expr.DateFormatClass.allowIncompatible=true, but results may differ from Spark.See #3202 for tracking full timezone support.
Test Plan
CometTemporalExpressionSuite:allowIncompatibleconfig for non-UTC timezonesCloses #3088