fix: native shuffle now reports spill metrics correctly#3197
Merged
mbutrovich merged 3 commits intoapache:mainfrom Jan 16, 2026
Merged
fix: native shuffle now reports spill metrics correctly#3197mbutrovich merged 3 commits intoapache:mainfrom
mbutrovich merged 3 commits intoapache:mainfrom
Conversation
andygrove
commented
Jan 15, 2026
|
|
||
| fn spill(&mut self) -> Result<()> { | ||
| log::debug!( | ||
| log::info!( |
Member
Author
There was a problem hiding this comment.
This makes logging consistent with JVM shuffle
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3197 +/- ##
============================================
+ Coverage 56.12% 59.85% +3.72%
- Complexity 976 1415 +439
============================================
Files 119 168 +49
Lines 11743 15589 +3846
Branches 2251 2590 +339
============================================
+ Hits 6591 9331 +2740
- Misses 4012 4948 +936
- Partials 1140 1310 +170 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mbutrovich
approved these changes
Jan 16, 2026
Contributor
mbutrovich
left a comment
mbutrovich
left a comment
There was a problem hiding this comment.
Thanks @andygrove! This is helpful for debugging production workloads!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Native shuffle was not reporting spill metrics correctly. They were not appearing in the task metrics.
With this PR:
What changes are included in this PR?
How are these changes tested?