feat: Expand murmur3 hash support to complex types#3077
Merged
mbutrovich merged 8 commits intoapache:mainfrom Jan 14, 2026
Merged
feat: Expand murmur3 hash support to complex types#3077mbutrovich merged 8 commits intoapache:mainfrom
murmur3 hash support to complex types#3077mbutrovich merged 8 commits intoapache:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3077 +/- ##
============================================
+ Coverage 56.12% 59.50% +3.37%
- Complexity 976 1370 +394
============================================
Files 119 167 +48
Lines 11743 15560 +3817
Branches 2251 2586 +335
============================================
+ Hits 6591 9259 +2668
- Misses 4012 5002 +990
- Partials 1140 1299 +159 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Jan 13, 2026
| // Hash each element in sequence, chaining the hash values | ||
| for elem_idx in 0..len { | ||
| let elem_array = values.slice(start + elem_idx, 1); | ||
| let mut single_hash = [*hash]; |
Contributor
There was a problem hiding this comment.
why is single_hash an array?
Member
Author
There was a problem hiding this comment.
single_hash is an array because the recursive hash method interface expects a slice of hashes and this allows us to reuse that rather than add another version of the code
mbutrovich
reviewed
Jan 13, 2026
mbutrovich
reviewed
Jan 13, 2026
| * These tests verify that Comet's native implementation of murmur3 hash produces identical | ||
| * results to Spark's implementation for all supported data types. | ||
| */ | ||
| class CometHashExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelper { |
Contributor
There was a problem hiding this comment.
Should we add this expression to one of the fuzz suites?
Member
Author
There was a problem hiding this comment.
Sure. Are you thinking more about the fuzz data generation aspect, or testing across different scans/shuffles, or both?
Contributor
There was a problem hiding this comment.
Mostly just interested in the fuzz data generation, seems like a good schema to throw at this.
Member
Author
There was a problem hiding this comment.
yup, that already uncovered a bug 💪
mbutrovich
reviewed
Jan 13, 2026
Member
Author
|
mbutrovich
approved these changes
Jan 14, 2026
Contributor
mbutrovich
left a comment
mbutrovich
left a comment
There was a problem hiding this comment.
Thanks for adding the benchmark! I have a followup PR to improve performance, I think. Let's go with this for now though. Thanks again @andygrove!
This was referenced Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
This is needed for the following features:
What changes are included in this PR?
How are these changes tested?