chore: deprecate native_comet scan in favor of native_iceberg_compat#2949
Merged
andygrove merged 3 commits intoapache:mainfrom Jan 16, 2026
Merged
Conversation
andygrove
reviewed
Dec 20, 2025
Co-authored-by: Andy Grove <[email protected]>
Contributor
|
@Shekharrajak , please run |
Contributor
Author
This is done already. |
Contributor
|
@Shekharrajak , seems like the formatting is still an issue ? |
Contributor
|
@Shekharrajak could also please link the issue you are closing so that there is no duplicate work associated? |
Contributor
Author
|
Ref #2949 comment native_iceberg_compat |
Contributor
|
Thank you |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2949 +/- ##
============================================
+ Coverage 56.12% 59.59% +3.46%
- Complexity 976 1377 +401
============================================
Files 119 167 +48
Lines 11743 15496 +3753
Branches 2251 2569 +318
============================================
+ Hits 6591 9235 +2644
- Misses 4012 4962 +950
- Partials 1140 1299 +159 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add deprecation annotation to SCAN_NATIVE_COMET and update documentation to recommend native_iceberg_compat. The legacy scan uses mutable buffers incompatible with Arrow FFI best practices.
Ref #2949