Skip to content

fix: Comet sink operator should not have children operators - #26

Merged
viirya merged 1 commit into
apache:mainfrom
viirya:fix_sink
Feb 15, 2024
Merged

viirya merged 1 commit into
apache:mainfrom
viirya:fix_sink

Conversation

@viirya

@viirya viirya commented Feb 15, 2024 •

Copy link
Copy Markdown
Member

Which issue does this PR close?

Closes #25.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@viirya viirya left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is from internal Comet patches which added after we cut open source branch.

@sunchao sunchao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viirya
viirya merged commit 50470bd into apache:main Feb 15, 2024
@viirya

viirya commented Feb 15, 2024

Copy link
Copy Markdown
Member Author

Merged. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comet sink operator should not have children operators

2 participants