chore: new TPC-DS golden plans#2426
Merged
mbutrovich merged 1 commit intoapache:mainfrom Sep 20, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2426 +/- ##
============================================
+ Coverage 56.12% 57.82% +1.70%
- Complexity 976 1400 +424
============================================
Files 119 147 +28
Lines 11743 13464 +1721
Branches 2251 2341 +90
============================================
+ Hits 6591 7786 +1195
- Misses 4012 4444 +432
- Partials 1140 1234 +94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mbutrovich
changed the title
Contributor
|
like here However I'm wondering why unscaled sum still in place I'll check this later and if needed regerenerate the golden plans |
Contributor
|
it is okay in terms of plan validity, didn't find invalid plan nodes, but Comet |
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Noticed a test branch failing
make test-jvmlocally, switch tomainand that fails too. Unclear why CI didn't catch this. I think it's from #2409 since it's all hash aggregates.What changes are included in this PR?
New plans.
How are these changes tested?
https://datafusion.apache.org/comet/contributor-guide/development.html#plan-stability-testing