Skip to content

feat: support map_entries#2059

Merged
comphead merged 1 commit intoapache:mainfrom
comphead:dev1
Aug 1, 2025
Merged

feat: support map_entries#2059
comphead merged 1 commit intoapache:mainfrom
comphead:dev1

Conversation

@comphead
Copy link
Contributor

@comphead comphead commented Aug 1, 2025

Which issue does this PR close?

Closes #1916 .

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.78%. Comparing base (f09f8af) to head (e59274b).
⚠️ Report is 342 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2059      +/-   ##
============================================
+ Coverage     56.12%   58.78%   +2.65%     
- Complexity      976     1252     +276     
============================================
  Files           119      137      +18     
  Lines         11743    13174    +1431     
  Branches       2251     2373     +122     
============================================
+ Hits           6591     7744    +1153     
- Misses         4012     4197     +185     
- Partials       1140     1233      +93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@comphead comphead requested a review from parthchandra August 1, 2025 21:46
@comphead comphead marked this pull request as ready for review August 1, 2025 21:46
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @comphead

@andygrove
Copy link
Member

Do we need to add this to the list of supported expressions in the documentation?

@comphead
Copy link
Contributor Author

comphead commented Aug 1, 2025

Do we need to add this to the list of supported expressions in the documentation?

Thanks @andygrove I'll create a followup on the documentation, I realized none of already supported Map methods are described in expressions.md

@comphead comphead merged commit a91498d into apache:main Aug 1, 2025
133 of 134 checks passed
coderfender pushed a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support map_entries function

3 participants