Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2040 +/- ##
============================================
+ Coverage 56.12% 58.75% +2.63%
- Complexity 976 1253 +277
============================================
Files 119 137 +18
Lines 11743 13164 +1421
Branches 2251 2390 +139
============================================
+ Hits 6591 7735 +1144
- Misses 4012 4196 +184
- Partials 1140 1233 +93 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This PR apache/datafusion#16290 changed the signature for some functions to return Utf8View. I can start bringing in changes to support Utf8View from my branch (https://github.com/mbutrovich/datafusion-comet/tree/german_style_strings) but this has a huge blast radius for Comet. I'll investigate further. |
|
Fixed windows and crypto tests, the It has something with Batch size and number of input files. |
|
I ran TPC-H benchmarks locally and saw no difference in performance compared to main branch |
|
@mbutrovich @andygrove please have a look |
|
|
||
| let sort = Arc::new( | ||
| SortExec::new(LexOrdering::new(exprs?), Arc::clone(&child_copied)) | ||
| SortExec::new(LexOrdering::new(exprs?).unwrap(), Arc::clone(&child_copied)) |
There was a problem hiding this comment.
note for other reviewers: the unwrap() here is on an Option. This seems safe because it would only be None if the vector of sort expressions were empty.
Which issue does this PR close?
A followup on #1997
Closes #1993 .
Rationale for this change
What changes are included in this PR?
How are these changes tested?