Merged
Conversation
added 2 commits
June 25, 2025 22:33
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1932 +/- ##
============================================
+ Coverage 56.12% 58.67% +2.54%
- Complexity 976 1145 +169
============================================
Files 119 133 +14
Lines 11743 13029 +1286
Branches 2251 2411 +160
============================================
+ Hits 6591 7645 +1054
- Misses 4012 4168 +156
- Partials 1140 1216 +76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Thanks @andygrove! |
9 tasks
andygrove
reviewed
Jun 28, 2025
|
|
||
| import org.apache.comet.testing.{DataGenOptions, ParquetGenerator} | ||
|
|
||
| class CometMapExpressionSuite extends CometTestBase { |
Member
There was a problem hiding this comment.
This new suite will need to be added in .github/workflows/pr_build_linux.yml and .github/workflows/pr_build_macos.yml before it can run in CI. I noticed that the CometBitwiseExpressionSuite suite also needs to be added.
andygrove
approved these changes
Jul 9, 2025
Member
andygrove
left a comment
andygrove
left a comment
There was a problem hiding this comment.
LGTM. Thanks @kazantsev-maksim
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to Epic: #1044
Spark: https://spark.apache.org/docs/latest/api/sql/index.html#map_from_arrays
Rationale for this change
Defined under Epic: #1044
What changes are included in this PR?
How are these changes tested?
A new UT has been added.