Skip to content

[ignore] test DataFusion PR: Fix constant window for evaluate stateful#1913

Closed
andygrove wants to merge 2 commits intoapache:mainfrom
andygrove:test-window-fix
Closed

[ignore] test DataFusion PR: Fix constant window for evaluate stateful#1913
andygrove wants to merge 2 commits intoapache:mainfrom
andygrove:test-window-fix

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented Jun 19, 2025 •
edited
Loading

Which issue does this PR close?

N/A

Rationale for this change

We would like to see if apache/datafusion#16430 fixes issues that we encountered during the DataFusion 48 upgrade.

What changes are included in this PR?

Pin to specific DataFusion rev

How are these changes tested?

@andygrove andygrove closed this Jun 19, 2025
@suibianwanwank
Copy link

suibianwanwank commented Jun 19, 2025

@andygrove If you have time, could you try the branch at https://github.com/suibianwanwank/datafusion/tree/48_fix? This branch is based on DF48 and includes the revert commit along with its fixes. Thanks!

@andygrove andygrove reopened this Jun 19, 2025
@andygrove
Copy link
Member Author

andygrove commented Jun 19, 2025

@andygrove If you have time, could you try the branch at https://github.com/suibianwanwank/datafusion/tree/48_fix? This branch is based on DF48 and includes the revert commit along with its fixes. Thanks!

@suibianwanwank I updated the rev in this PR

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.78%. Comparing base (f09f8af) to head (358d3ce).
Report is 271 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1913      +/-   ##
============================================
+ Coverage     56.12%   58.78%   +2.66%     
- Complexity      976     1141     +165     
============================================
  Files           119      130      +11     
  Lines         11743    12831    +1088     
  Branches       2251     2414     +163     
============================================
+ Hits           6591     7543     +952     
- Misses         4012     4065      +53     
- Partials       1140     1223      +83

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suibianwanwank suibianwanwank mentioned this pull request Jun 20, 2025
Merged
@andygrove andygrove closed this Jun 20, 2025
@andygrove andygrove deleted the test-window-fix branch July 10, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andygrove @suibianwanwank @codecov-commenter