chore: Ignore Spark SQL WholeStageCodegenSuite tests#1859
Merged
andygrove merged 5 commits intoapache:mainfrom Jun 7, 2025
Merged
chore: Ignore Spark SQL WholeStageCodegenSuite tests#1859andygrove merged 5 commits intoapache:mainfrom
andygrove merged 5 commits intoapache:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1859 +/- ##
============================================
+ Coverage 56.12% 59.41% +3.28%
- Complexity 976 1151 +175
============================================
Files 119 130 +11
Lines 11743 12667 +924
Branches 2251 2376 +125
============================================
+ Hits 6591 7526 +935
+ Misses 4012 3930 -82
- Partials 1140 1211 +71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5 tasks
YanivKunda
pushed a commit
to YanivKunda/datafusion-comet
that referenced
this pull request
Jun 8, 2025
YanivKunda
pushed a commit
to YanivKunda/datafusion-comet
that referenced
this pull request
Jun 8, 2025
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1852
Rationale for this change
WholeStageCodegenSuitecontains tests that assert that certain operators, such as joins, appear in aWholeStageCodegenExec. Comet does not support codegen, so these tests will fail when running natively.We had previously updated some of these tests to make them work by changing the assertions to state that it was ok for Comet operators to not be in a
WholeStageCodegenExecand in other cases by disabling Comet, but these are changing the very nature of the tests.Since we do not support codegen, we should not expect to pass the codegen tests.
What changes are included in this PR?
How are these changes tested?