Repository navigation
chore: Enable tests in RemoveRedundantProjectsSuite.scala related to issue #242 - #1838
Merged
Merged
Conversation
andygrove
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1838 +/- ##
============================================
+ Coverage 56.12% 59.42% +3.29%
- Complexity 976 1151 +175
============================================
Files 119 130 +11
Lines 11743 12660 +917
Branches 2251 2373 +122
============================================
+ Hits 6591 7523 +932
+ Misses 4012 3928 -84
- Partials 1140 1209 +69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@andygrove could I get reviews here? |
andygrove
approved these changes
Jun 4, 2025
Member
|
We'll need to make the same change in 4.0.0 later #1846 |
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Addresses #1739
Rationale for this change
Enables tests in
RemoveRedundantProjectsSuite.scalarelated to #242. The Comet now falls back to Spark for Dynamic Partition Pruning. These tests can now be enabled.The other ask to enable tests in
InjectRuntimeFilterSuitewere already addressed here: #1837What changes are included in this PR?
Updates the apache-spark
3.5.5.diffto enable tests.How are these changes tested?
3.5.5.diffto apache-spark-3.5RemoveRedundantProjectsSuitesuite.