Skip to content

fix: Enable more Spark SQL tests - #1834

Merged
andygrove merged 2 commits into
apache:mainfrom
andygrove:issue-1831
Jun 3, 2025
Merged

andygrove merged 2 commits into
apache:mainfrom
andygrove:issue-1831

Conversation

@andygrove

@andygrove andygrove commented Jun 3, 2025 •

Copy link
Copy Markdown
Member

Which issue does this PR close?

Closes #1831

Rationale for this change

All InjectRuntimeFilterSuite tests can be enabled now that #1737 is fixed.

I also enabled additional tests that are now passing.

What changes are included in this PR?

How are these changes tested?

@andygrove
andygrove marked this pull request as ready for review June 3, 2025 13:38
@andygrove andygrove changed the title fix: Enable InjectRuntimeFilterSuite Spark SQL tests fix: Enable more Spark SQL tests Jun 3, 2025
@codecov-commenter

codecov-commenter commented Jun 3, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.43%. Comparing base (f09f8af) to head (b1e4b05).
Report is 234 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1834      +/-   ##
============================================
+ Coverage     56.12%   59.43%   +3.30%     
- Complexity      976     1151     +175     
============================================
  Files           119      130      +11     
  Lines         11743    12660     +917     
  Branches       2251     2373     +122     
============================================
+ Hits           6591     7524     +933     
+ Misses         4012     3928      -84     
- Partials       1140     1208      +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@comphead comphead left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @andygrove

@andygrove
andygrove merged commit 41b9a45 into apache:main Jun 3, 2025
@andygrove
andygrove deleted the issue-1831 branch June 3, 2025 15:14
coderfender pushed a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants