Merged
Conversation
comphead
changed the title
map_values, map_keys
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1788 +/- ##
============================================
+ Coverage 56.12% 59.46% +3.34%
- Complexity 976 1140 +164
============================================
Files 119 128 +9
Lines 11743 12531 +788
Branches 2251 2356 +105
============================================
+ Hits 6591 7452 +861
+ Misses 4012 3889 -123
- Partials 1140 1190 +50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
|
Closed
parthchandra
approved these changes
May 27, 2025
Contributor
parthchandra
left a comment
parthchandra
left a comment
There was a problem hiding this comment.
lgtm. (Some minor comments)
native/core/src/execution/planner.rs
Outdated
| let session_ctx = SessionContext::new(); | ||
|
|
||
| // generate test data in the temp folder | ||
| let test_data = "select map([named_struct('a', 1, 'b', 'n', 'c', 'x')], [named_struct('a', 1, 'b', 'n', 'c', 'x')]) c0"; |
Contributor
There was a problem hiding this comment.
minor: can we use a different struct for the key and the value, just to make it clear we are reading the correct fields.
| sqlConf: Seq[(String, String)] = Seq.empty, | ||
| debugCometDF: DataFrame => Unit = _ => ()): Unit = { | ||
| debugCometDF: DataFrame => Unit = _ => (), | ||
| checkCometOperator: Boolean = true): Unit = { |
Contributor
Author
There was a problem hiding this comment.
does not related directly, but this extends testing method functionality little bit to support tests which doesn't require all native comet operators. Used this extension to find that map_keys projection is not supported
native/core/src/execution/planner.rs
Outdated
| select map(named_struct('a', 1, 'b', 'n', 'c', 'x'), named_struct('a', 1, 'b', 'n', 'c', 'x')) m | ||
| */ | ||
| #[tokio::test] | ||
| async fn test_nested_types_map_keys_by_index() -> Result<(), DataFusionError> { |
Contributor
There was a problem hiding this comment.
nit: what does the by_index part of the name refer to?
andygrove
reviewed
May 27, 2025
| "select map_keys(c0).b from tbl") | ||
| } | ||
|
|
||
| // test("native reader - select nested field from a complex map key using map_values") { |
Member
There was a problem hiding this comment.
Should this test be ignored with a link to an issue rather than commented out?
andygrove
approved these changes
May 27, 2025
kazuyukitanimura
approved these changes
May 27, 2025
Contributor
Author
|
Thanks everyone |
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
* fix: support `map_keys`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1781.
Rationale for this change
What changes are included in this PR?
How are these changes tested?