chore: Enable partial Spark SQL tests for native_iceberg_compat scan#1762
Merged
andygrove merged 1 commit intoapache:mainfrom May 21, 2025
Merged
chore: Enable partial Spark SQL tests for native_iceberg_compat scan#1762andygrove merged 1 commit intoapache:mainfrom
native_iceberg_compat scan#1762andygrove merged 1 commit intoapache:mainfrom
Conversation
andygrove
commented
May 21, 2025
| matrix: | ||
| os: [ubuntu-24.04] | ||
| java-version: [11] | ||
| spark-version: [{short: '3.5', full: '3.5.5'}] |
Member
Author
There was a problem hiding this comment.
This is intentional to just run with one Spark version for now. Once all tests are passing for 3.5.5 we can extend to other versions.
andygrove
commented
May 21, 2025
Comment on lines
+89
to
+96
| - {name: "catalyst", args1: "catalyst/test", args2: ""} | ||
| # - {name: "sql/core-1", args1: "", args2: sql/testOnly * -- -l org.apache.spark.tags.ExtendedSQLTest -l org.apache.spark.tags.SlowSQLTest} | ||
| # - {name: "sql/core-2", args1: "", args2: "sql/testOnly * -- -n org.apache.spark.tags.ExtendedSQLTest"} | ||
| - {name: "sql/core-3", args1: "", args2: "sql/testOnly * -- -n org.apache.spark.tags.SlowSQLTest"} | ||
| # - {name: "sql/hive-1", args1: "", args2: "hive/testOnly * -- -l org.apache.spark.tags.ExtendedHiveTest -l org.apache.spark.tags.SlowHiveTest"} | ||
| - {name: "sql/hive-2", args1: "", args2: "hive/testOnly * -- -n org.apache.spark.tags.ExtendedHiveTest"} | ||
| - {name: "sql/hive-3", args1: "", args2: "hive/testOnly * -- -n org.apache.spark.tags.SlowHiveTest"} | ||
| fail-fast: false |
Member
Author
There was a problem hiding this comment.
On the last run of these tests in CI ~2 weeks ago, the failing counts were:
core-1: 21
core-2: 19
hive-1: 3
The other tests had no failures
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1762 +/- ##
============================================
+ Coverage 56.12% 58.60% +2.47%
- Complexity 976 1138 +162
============================================
Files 119 130 +11
Lines 11743 12663 +920
Branches 2251 2362 +111
============================================
+ Hits 6591 7421 +830
- Misses 4012 4058 +46
- Partials 1140 1184 +44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andygrove
changed the title
native_iceberg_compat scan
kazuyukitanimura
approved these changes
May 21, 2025
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Some of the Spark SQL test suites are already passing when using
native_iceberg_compat, so we may as well make those part of CI now.What changes are included in this PR?
How are these changes tested?