perf: Use a global tokio runtime#1614
Merged
andygrove merged 3 commits intoapache:mainfrom Apr 8, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1614 +/- ##
============================================
+ Coverage 56.12% 58.55% +2.42%
- Complexity 976 1063 +87
============================================
Files 119 125 +6
Lines 11743 12582 +839
Branches 2251 2374 +123
============================================
+ Hits 6591 7367 +776
- Misses 4012 4020 +8
- Partials 1140 1195 +55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@Kontinuation @wForget could you review? |
Kontinuation
approved these changes
Apr 7, 2025
Member
Author
|
@comphead @parthchandra could I get a committer review? |
Member
Author
|
Thanks for the reviews @Kontinuation @wForget @parthchandra |
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1590
Helps with #1523
Rationale for this change
If I configure Spark executor with 8GB + 1GB offHeap and using default settings for tokio threads, q4 hangs in main branch, but completes with these changes.
What changes are included in this PR?
Based on an executor configured for 8 concurrent tasks and 1 core per task, the defaults for the overall process now change as follows:
How are these changes tested?
Manual testing. I do not see any change in overall TPC-H performance, but I can now get q4 to complete with less memory than before.
Note that we cannot close #1523 until apache/datafusion#15323 is resolved.