Skip to content

feat: add MAP type support for first level#1603

Merged
comphead merged 5 commits intoapache:mainfrom
comphead:dev1
Apr 9, 2025
Merged

feat: add MAP type support for first level#1603
comphead merged 5 commits intoapache:mainfrom
comphead:dev1

Conversation

@comphead
Copy link
Contributor

@comphead comphead commented Apr 3, 2025

Which issue does this PR close?

Related #1595.

Rationale for this change

Adding a first level MAP datatype support for native DataFusion reader

What changes are included in this PR?

How are these changes tested?

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 58.97%. Comparing base (f09f8af) to head (5228374).
Report is 131 commits behind head on main.

Files with missing lines Patch % Lines
.../scala/org/apache/spark/sql/comet/util/Utils.scala 0.00% 2 Missing ⚠️
.../scala/org/apache/comet/serde/QueryPlanSerde.scala 50.00% 0 Missing and 1 partial ⚠️
...g/apache/spark/sql/comet/CometNativeScanExec.scala 0.00% 0 Missing and 1 partial ⚠️
...ala/org/apache/spark/sql/comet/CometScanExec.scala 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1603      +/-   ##
============================================
+ Coverage     56.12%   58.97%   +2.84%     
- Complexity      976     1067      +91     
============================================
  Files           119      125       +6     
  Lines         11743    12531     +788     
  Branches       2251     2344      +93     
============================================
+ Hits           6591     7390     +799     
+ Misses         4012     3973      -39     
- Partials       1140     1168      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@comphead
Copy link
Contributor Author

comphead commented Apr 4, 2025

Some of failing tests with MapVector could be fixed like #1610 (comment)

Copy link
Contributor

@parthchandra parthchandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@comphead comphead merged commit ba53a7f into apache:main Apr 9, 2025
79 checks passed
coderfender pushed a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
* feat: add MAP type support for first level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants